PB, request for code review and merge back(2)

PhracturedBlue wrote: It would be helpful if you change Eclipse to use spaces rather than tabs in the future. I keep needing to remember to remove all the tabs as I do the import.

Will do

sbstnp wrote: by the way, any special build procedure for devo 10? I built a dfu earlier and after transferred to my devo10 it doesn't start, shows just a corrupted screen, so I returned to walkera's firmware.

what could cause this?

copy all files and folders under $Projectsrc\filesystem\devo10 to your devo10's USB drive(press ENT when power on)

I don't reach that phase, screen gets corrupted and then nothing. Same thing when ENT or no ENT. Must be something else.

got the merged codes

Anh reason for changing the button style?

Just merge with your latest update , please check them out and merge again:
1) I remove all traditional mixer stuffs at this moment , which will let your code diff easier
2) I fixed 2 new critical bugs when testing with real devo10:
a) When the safety dialog poped up in the middle of any page opened, it won't get dismissed any more. It is because d10's pages all have a default selected widget to simplify user's navigating. however, this will grab the dialog's selecting focus so the dialog got stuck.
b) the safety dialog keeps interrupt calibration if auto-safe is set ON. I make a quick-fix which works in emulator. However, I found that current calibration won't work in real devo10 any more. I might rever it back to my previous logic.
2) Please synced with my changed in the lcd_gfx.c and channel.c, containing important bug fix. Otherwise, pages might crashed with more than 1 page and the sticks are not mapped correctly.

I am still working on fixing calibration issues in real device， also need to make the reorder_list page work in devo10 as it will crash the complex template.
Hopefully, we can release an alpha version for integration test fly during this weekend and meet my estimated schedule

Already fix calibration bug and verify it in real devo10. Please check it with your real devo8 to make sure it works as well

Reorderlist(Only in the mixer curve page. I don't really think it is a must-have in the mixer_page at this moment） and usb pages are all ported to devo10. The alpha version can be released for testing now

suvsuv wrote: Reorderlist(Only in the mixer curve page. I don't really think it is a must-have in the mixer_page at this moment） and usb pages are all ported to devo10. The alpha version can be released for testing now

I'm all for an alpha version as there is something wrong with my arm toolchain - I used something else than summon-arm-toolchain. Last night I got to the point where I saw the USB symbol, copied the filesystem but never got past that stage, TX would reboot and corrupt the USB storage.

But well, my problem

Test the fonts in both devo8 and devo10,
In devo8 , font15 is the best, even font15_wqy is way better than the 12narrow, please replace current 12narrow with this one.
In devo10, the 12serif is the best, both font12 and font12_wqy are kind of too tall.
Thanks for bringing such good fonts for Chinese languages

There are only 4 warnings in building devo10 i, I am on purposely leaving it there as it will remind me of refactoring the current protocolselection&binding page. There should be no any warning in building devo8 and devo6

PhracturedBlue wrote: Try this font. it is 11pt instead of 12pt, but it is built with firefly so hopefully it looks ok in Chinese. I decided on the smaller font because it works much better with Russian, and looks good in English on the Devo10.

If it isn't usable, I can try to splice the 12px CJK characters into the 11px latin/cyrillic.

Note that the 12serif font doesn't have full language support, so we can't keep it as is.

This font is not as good as 12serif as it can't show clearly for both Simplified and Traditional Chinese

Just synced with your lastest update, not found the new 12serif font, you should forgot to have it submitted.

Please check out my new codes, including:
1) move main_page's shared callbacks to pages/common folder
2) Allow changing TX power on the fly, but only apply to devo10 at the moment, since I don't have devo8 to verify it. The codes are added in the protocol.c as per your suggestion
3) Currently, you can just ignore the main.c for which you still have concerns.