PB, request for code review and merge back(2)

PhracturedBlue
Offline

31 Dec 2012 13:32 #4426 by PhracturedBlue

Replied by PhracturedBlue on topic PB, request for code review and merge back(2)

All changes made.
I will also be renaming the files/directories with 'simple' to 'standard' but I want to make really sure I don't have to do it again, so I've deferred it for the moment. Since I now use a name in the ini file, once we settle on the names, it can't be changed again.

Please Log in or Create an account to join the conversation.

suvsuv
Topic Author
Offline

02 Jan 2013 10:16 #4512 by suvsuv

Replied by suvsuv on topic PB, request for code review and merge back(2)

PhracturedBlue wrote: All changes made.
I will also be renaming the files/directories with 'simple' to 'standard' but I want to make really sure I don't have to do it again, so I've deferred it for the moment. Since I now use a name in the ini file, once we settle on the names, it can't be changed again.

Standard is fine. Please go ahead renaming the files/directories so that I can sync with your update. Thanks

Please Log in or Create an account to join the conversation.

suvsuv
Topic Author
Offline

02 Jan 2013 11:40 #4515 by suvsuv

Replied by suvsuv on topic PB, request for code review and merge back(2)

Please check out the following updates:
1)dialogs.c: String of renaming Simple to Standard
2)simple\drexp_page.c: i18n string for Invalid model ini
3)_mixer_setup.c: bug fix for open issue #191
4) lang.cn & lang.tw

Please Log in or Create an account to join the conversation.

suvsuv
Topic Author
Offline

05 Jan 2013 05:42 #4683 by suvsuv

Replied by suvsuv on topic PB, request for code review and merge back(2)

Made changes for the following items:

1) Bug fix on setting Pit curve for Thr hold
2) Allow max safety value to be +/-150
3) Allow max DR to 125

Please Log in or Create an account to join the conversation.

Time to create page: 0.034 seconds

Force desktop display