PB, request for code review and merge back(2)

PhracturedBlue wrote: Also, can you go through the issues here:
bitbucket.org/PhracturedBlue/deviation/i...atus=new&status=open

that are related to the Devo10 and see which can be closed? I think most/all of them.

Yes, I am keeping track of bugs related to devo10. For those bugs that I replied with fixed, please have them closed as I don't have privilege to do so.

BTW, will you replace the 12narrow font with 12normal font for devo8?

1) The auto dimmer feature is in. While I am working on its configure pages ,please take a look at its current logic and let me know if you want a higher frequency for the back-light scanning
2) Fix a major bug in calibration

PhracturedBlue wrote: Auto-dimmer is not on bitbucket, so I can't review

I don't get your point. When adding a feature , must I create a bug on the bitbucket?

FDR wrote: I think he meant you haven't pushed it yet...

Sorry, my network's issue and I don't realize it was broken in the middle of pushing. Just pushed codes in.

PhracturedBlue wrote: Overall, the autodim feature looks ok.
2 things:
1) why do you need to check it in the GUI? I don't think that is the right place to check the Dimmer. in the main loop (for powerdown) and in the button and touch handlers (for power up) should be sufficient, it seems to me.

Changed as per your suggestion

PhracturedBlue wrote: 2) I don't see any value in your low-priority functions. The screen update at 100msec is low speed enough for anything we need in my opinion, so just put it there.

I don't see the need to check back-light as quick as once per 100msec. once per seconde is sufficient for this low priority task. But this is not a blocking issue for both you and me, so you can just move the backlight checking into the redraw loop in your repo.

Today I make quite a few checkin, please take a look and have them merged back to your repo:
1) Merged your latest update except change related Expo&DR in the mixer setup
2) Provide configuration UI for auto-dimmer setting in both devo10 and devo8, please verify it in your devo8 TX
2) In the Expo&Dr setting page, you moved 2 graphes from mixer setup into its subpage. This is not a good solution, compared with my current one. What I do is to have them switched to the active viewpoint based on what left item is selected.
2) Fix improper font setting for the timer in the main page when time is up. The config.ini under filesystem/devo10/media must be merged back
3) Fix bug about drawing BMP in devo10

when navigating among different switch items in the left view, their corresponding graph will be switched to show to the right. I got a user request to watch xygraphes in the same page instead
of entering and exiting subpages from time to time

PhracturedBlue wrote: I didn't realize it worked that way. It is certainly not inuitive. maybe at least show some text indicating what is being displayed? It would be somewhat more intuitive, and would make it more clear what was going on.

No matter how we do ,the deviation is not a easy-to-use system for new users. A manual is needed instead of putting tutorial items.

PhracturedBlue wrote: Also, I'm not yet convinced of using sub-pages for the expo-d/R. it makes configuration very slow. I think I'd rather just have a couple more text-selects on the main page.

That is what I am going to do. But man, you should give me some patient as I already drive out this system to devo10 very quick. Currently, I only slow down a little bit and focus on bug-fixing in order to let the deviation10 becomes a stable build.

PhracturedBlue wrote:
We are now close enough to doing a proper release that I want to make sure the interface is in its final state (for this release). Before release, I need to write the documentation, and it takes me a long time to do documentation. If the interface changes, I need to redo it, so having the interface stable is important to the final steps.

Do you have any plans to have a customizeable main page like we do for the devo8? We're obviously more limited in space, but (for instance) being able to configure whether the model image is shown, or that space supports text boxes or toggles would probably be very helpful. Please let me know what your plans are in this regard.

So far, the deviation10 is proved to be quite stable from what I heard from about 5 test users.
And most of the bugs that we knew have been fixed.
In the weekend, I will improve the Expo&DR page to draw all items into the same page.
In terms of the customizeable main page, could you give me some suggestion about what you want to configure， then I will get it done this weekend also. Of coz, please take the LCD resolution constraint into account