Proposed change to main page channel display

This change fixes the problem described in this post . The current proposed diff is here , but may be further changes based on this discussion. Three items to consider...

This change has a side effect that seems beneficial to me but would like to know if the current behavior has a reason. Currently values of the real output channels (CH1-CHxx) displayed on the main page in boxes and bars are taken from the mixer output, but with only the safety limit applied (and scale for percentages). Why is this? These values may not be the same as the values used by the protocols, so don't necessarily reflect what's being sent to the aircraft. The proposed change displays the values used by the protocols, which have all limits applied.

Second, the mixer output (subject only to safety limit) is also used in timer.c, the safety dialog, and the safety check in protocol.c. Also for these cases it seems to me better to use the final channel values. I propose changing the calls to MIXER_GetChannel to MIXER_GetFinalChannel in these cases also (which eliminates all uses of GetChannel so it could be removed). Would there be any issues with that? For example, with this change if the student's PPM signal violates the safety check the safety dialog would be displayed.

Finally, MIXER_GetChannel calls MIXER_ApplyLimits, which has the side effect of updating channels with non-zero Speed settings. I think this is a bug because the code looks like it should only run every 5 msec. Updating with the main page refresh would introduce about 5% error for every place the channel is displayed (if I read the code right). Removing the call to MIXER_ApplyLimits eliminates this issue.

No, perfect...now I understand. Makes sense to me. I ask because I haven't been in RC long enough to know.

Do you think the behavior described in the post (main screen channel values are not updated when PPM In is set to Channel) is worth fixing? GetChannel could replace the mixer output with ppmChannels like CalcChannels does, but not sure how that would affect its use for timers and safety. Would be nice if the instructor could see students values, but this is pretty expert set up and would probably be tested on the model anyway.

With your pointer on flags I looked more closely and there is no bug. The speed update only happens at the appropriate time.

hexfet wrote:
...Currently values of the real output channels (CH1-CHxx) displayed on the main page in boxes and bars are taken from the mixer output, but with only the safety limit applied (and scale for percentages). Why is this? These values may not be the same as the values used by the protocols, so don't necessarily reflect what's being sent to the aircraft. The proposed change displays the values used by the protocols, which have all limits applied.

...

I have been saying this for many many times in the past years and didn't get any response. It would be great if this silly display information can be corrected at last...

I've made the change suggested by PB. Pull request here .

Current behavior is unchanged except when PPM In is set to Channel and the trainer switch is ON. In this case the PPM input value will be used for:

• main page display channel values
• startup safety check
• safety dialog display value
• datalog enable
• value logged in datalog
• timer switch
• timer reset switch