Main page config hangs/reboots

Since I have my new 12E, I found a bug in the main page config, which seems to effect both the DEVO 10 and 12E, and probably any other BW transmitters that have a configurable main page, like the U7E, and all of those emulators too.

If you are on the main page config's list of fields, a long ENT takes you to the positioning window, where you can select a field, and with a short ENT you can change to move mode.
However if you press a long ENT there, the TX hangs and reboots, showing the USB screen after that.
The emulators crash too...

This is on a fresh build, the official 5.0 is not effected, it seems...

What has to be happened with ENT long press? Nothing or ???

Nothing special, but it can happen accidentally...

Fixed, I will place pull request.

Load/Save layout page work normally, I tested it by changing call at other page. So, button call at layout config dialog do nothing.

Interestingly, dialog page from which we try to call Load\Save layout page isn't Modal window? In that case button work normally, but PAGE_PushByID() do nothing.

I don't know how do it, but we need to close dialog before PAGE_PushByID().

pages\common\_main_config.c
It work, I can open "Load Layout" and load any layout. But, it can't compile for transmitters that have not dialog window.

Indeed, I tried the DEVO 8 emulator, and the template load doesn't work, but writes this onto the output:

vlad_vy wrote:

static void add_dlgbut_cb(struct guiObject *obj, const void *data)
{
    (void)obj;
    if(!data) {
        if (OBJ_IS_USED(&gui->dialog))
            GUI_RemoveHierObjects((guiObject_t *)&gui->dialog);
        PAGE_PushByID(PAGEID_LOADSAVE, LOAD_LAYOUT);
    }
}

This works for the DEVO 8.
What more do we need to check?

We need to move both version (modified and unmodified) "add_dlgbut_cb()" to 320x240x16 main_layout.c and 128x64x1 main_config.c, and remove from common\_main_config.c

I will place pull request.

It looks like we need temporarily open "Reporting bugs" topic or category, since "Bug tracker" is inaccessible.

PB didn't like the built-in bug tracker of neither the BitBucket, nor GitHub.
Our own had the advantage, that the users could report bugs without the need of a new registration and login, and they were still named users not just guests...

However since the Mantis integration is broken (since a Joomla upgrade there are a lot of naming conflicts), I have rather enabled the GitHub issue tracker in GitHub. It was enabled for the other two repositories anyway...