Main page config hangs/reboots

More
19 Jan 2017 19:23 - 19 Jan 2017 19:24 #58204 by FDR
Main page config hangs/reboots was created by FDR
Since I have my new 12E, I found a bug in the main page config, which seems to effect both the DEVO 10 and 12E, and probably any other BW transmitters that have a configurable main page, like the U7E, and all of those emulators too.

If you are on the main page config's list of fields, a long ENT takes you to the positioning window, where you can select a field, and with a short ENT you can change to move mode.
However if you press a long ENT there, the TX hangs and reboots, showing the USB screen after that.
The emulators crash too...

This is on a fresh build, the official 5.0 is not effected, it seems...
Last edit: 19 Jan 2017 19:24 by FDR.

Please Log in or Create an account to join the conversation.

More
06 Mar 2017 08:34 #59891 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
What has to be happened with ENT long press? Nothing or ???

Please Log in or Create an account to join the conversation.

More
06 Mar 2017 09:01 #59892 by FDR
Replied by FDR on topic Main page config hangs/reboots
Nothing special, but it can happen accidentally...

Please Log in or Create an account to join the conversation.

More
06 Mar 2017 09:32 #59893 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
Fixed, I will place pull request.

Please Log in or Create an account to join the conversation.

More
06 Mar 2017 15:44 #59902 by Moeder
Replied by Moeder on topic Main page config hangs/reboots
Another bug in current nightlies for main page configuration is, that on color touch screens (and emulators) nothing happens when pressing the load template button. Couldn't make out the reason yet unfortunately, but I have to admit I'm not that firm in the color GUI code...

Please Log in or Create an account to join the conversation.

More
07 Mar 2017 12:46 - 07 Mar 2017 12:47 #59948 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
Load/Save layout page work normally, I tested it by changing call at other page. So, button call at layout config dialog do nothing.
Last edit: 07 Mar 2017 12:47 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
07 Mar 2017 14:55 - 07 Mar 2017 16:53 #59957 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
Interestingly, dialog page from which we try to call Load\Save layout page isn't Modal window? In that case button work normally, but PAGE_PushByID() do nothing.

I don't know how do it, but we need to close dialog before PAGE_PushByID().

pages\common\_main_config.c
static void add_dlgbut_cb(struct guiObject *obj, const void *data)
{
    (void)obj;
    if(!data) {
        if ((guiObject_t *)&gui->dialog) {
            DialogClose((guiObject_t *)&gui->dialog, 0);
        }
        PAGE_PushByID(PAGEID_LOADSAVE, LOAD_LAYOUT);
    }
}

It work, I can open "Load Layout" and load any layout. But, it can't compile for transmitters that have not dialog window.
Attachments:
Last edit: 07 Mar 2017 16:53 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
07 Mar 2017 19:51 #59978 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
static void add_dlgbut_cb(struct guiObject *obj, const void *data)
{
    (void)obj;
    if(!data) {
        if (OBJ_IS_USED(&gui->dialog))
            GUI_RemoveHierObjects((guiObject_t *)&gui->dialog);
        PAGE_PushByID(PAGEID_LOADSAVE, LOAD_LAYOUT);
    }
}

Please Log in or Create an account to join the conversation.

More
07 Mar 2017 19:59 #59979 by FDR
Replied by FDR on topic Main page config hangs/reboots
Indeed, I tried the DEVO 8 emulator, and the template load doesn't work, but writes this onto the output:
ERROR: Page stack limit(6) exceeded

Please Log in or Create an account to join the conversation.

More
07 Mar 2017 20:08 #59980 by FDR
Replied by FDR on topic Main page config hangs/reboots

vlad_vy wrote:

static void add_dlgbut_cb(struct guiObject *obj, const void *data)
{
    (void)obj;
    if(!data) {
        if (OBJ_IS_USED(&gui->dialog))
            GUI_RemoveHierObjects((guiObject_t *)&gui->dialog);
        PAGE_PushByID(PAGEID_LOADSAVE, LOAD_LAYOUT);
    }
}


This works for the DEVO 8.
What more do we need to check?

Please Log in or Create an account to join the conversation.

More
08 Mar 2017 05:39 #59991 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
We need to move both version (modified and unmodified) "add_dlgbut_cb()" to 320x240x16 main_layout.c and 128x64x1 main_config.c, and remove from common\_main_config.c

I will place pull request.

Please Log in or Create an account to join the conversation.

More
08 Mar 2017 06:14 - 08 Mar 2017 06:16 #59993 by vlad_vy
Replied by vlad_vy on topic Main page config hangs/reboots
It looks like we need temporarily open "Reporting bugs" topic or category, since "Bug tracker" is inaccessible.
Last edit: 08 Mar 2017 06:16 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
08 Mar 2017 06:54 #59994 by Moeder
Replied by Moeder on topic Main page config hangs/reboots
Since the project has moved to GitHub, why not use their Issues system as well? This one should be answered bei PB/ FDR I suppose...

Please Log in or Create an account to join the conversation.

More
08 Mar 2017 07:48 #59995 by FDR
Replied by FDR on topic Main page config hangs/reboots
PB didn't like the built-in bug tracker of neither the BitBucket, nor GitHub.
Our own had the advantage, that the users could report bugs without the need of a new registration and login, and they were still named users not just guests...

However since the Mantis integration is broken (since a Joomla upgrade there are a lot of naming conflicts), I have rather enabled the GitHub issue tracker in GitHub. It was enabled for the other two repositories anyway...

Please Log in or Create an account to join the conversation.

Time to create page: 0.066 seconds
Powered by Kunena Forum