- Posts: 4402
- Forum
- News, Announcements and Feedback
- Feedback & Questions
- PB, request for code review and merge back(2)
PB, request for code review and merge back(2)
- PhracturedBlue
- Offline
Please Log in or Create an account to join the conversation.
- vlad_vy
- Offline
- Posts: 3333
suvsuv wrote: 3) If it is specificlly for dsm2, we should do it on for dsm2. In devo protocol, it doesn't make sense to ask user to delete the Protocol_ID first when switching from Non-fixedid to Fixed id
It's requested by Walkera users. With some models custom Fixed ID doesn't work, they can use only Protocol_ID as Fixed ID.
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
Note that I changed the semantics of the negative servo-scale.
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
Update lang.cn and lang.tw accordingly, please have them merged to your repoPhracturedBlue wrote: I've merged everything that I think I'm going to for now.
Note that I changed the semantics of the negative servo-scale.
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
The codes are in bitbucket.org/sunvsuv/devil10 , and synced with your latest codes
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
Thanks!
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
PhracturedBlue wrote: I do plan to incorporate it, but it will take a little time for me to go through the code and see if anything needs to be changed. I'll let you know what I find as I go.
Thanks!
Following the implementation in DSX9, I refactored MIXER_UpdateTrim() to generate different tones when trims are changed, please check them out
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
Mostly I took things as is, though I renamed 'Traditional' to 'Simple' and reorganized the file directories a little.
It probably needs some more cleanup. I made some changes that may need to be reverted/tweaked, bu tit should mostly be ok.
I'll look at the trim beeper soon.
Please Log in or Create an account to join the conversation.
- RugWarrior
- Offline
- Posts: 59
Please Log in or Create an account to join the conversation.
- RugWarrior
- Offline
- Posts: 59
Can you tell me what was wrong with the make clean up?
My problem with the "old" code was that it does not delete the "objs" folder for example and if I did "make devo6" and then "make clean" it did not clean devo6 stuff e.g. because devo8 is the default target.
My intention was to really clean up all files the "make" command did to keep the source code folder "clean"
But maybe I am missong something?!
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
So if you want to clean up devo6, you do:
make TARGET=devo6 clean
I need to work on a lot of different builds concurrently, and the compile time is actually a factor for me, so I am sensitive to this.
I would take a patch implementing:
make distclean
which would remove all build files for all platforms though.
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
I did not take all translations yet. I want to wait for the strings to stabilize before updates for the new 'simple' mixer
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
I have checked out all your update and have them updated into my repo. Everything looks great, but I have some minor changedPhracturedBlue wrote: I believe I've merged everyone's code now. Please let me know if I missed anything or any issues you see.
I did not take all translations yet. I want to wait for the strings to stabilize before updates for the new 'simple' mixer
a) Naming the GUI to "Simple" is not good. Firstly, it will confused users with the Simple template, especially after translated into other languges. Secondly, the Simple GUI is not simple, as it can do almost everything except Program Mix(I will add support for prog mix sooner or later) and free mapping of channels. Last but not least, all commercial TXes, such as Futaba, JR and Walkera, adopt this style of GUI, which means it is Common instead of Simple. So I would suggest to rename it to ”Enhanced" and "Common", or any better names you could come up with.
b) The older model ini uses mixermode=1 , so I add backward compatibility support in the model.c
c) In the _mixer_limit.c and _throttle_hold.c, I change the range of safeval to (-120, +120). When I config my mini Vbar, I have to adjust TRVADJ to (-105, +105) in order to let the Vbar outputs from -100 to +100. As a result, setting safeval to -100 in the TX only makes the vbar's throttle ouput to -95
d) In the drexp_page.c and _drexp_page.c, allow "LIN" to be a i18n string
c) Update lang.cn and lang.tw
e) In the wk2x01.c, options for "COL Inv" should be "Normal" and "Inverted", instead of "On" and "Off"
Please Log in or Create an account to join the conversation.
- RandMental
- Offline
- Posts: 521
Please Log in or Create an account to join the conversation.
- vlad_vy
- Offline
- Posts: 3333
Please Log in or Create an account to join the conversation.
- domcars0
- Offline
- Posts: 390
I vote for : 'Standard' and 'Enhanced'
Have an happy new year!
Devo 10 (+7e) owner. It's mine, please don't touch it with your big fingers
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
I agree with you, but the problem is that with the way things are saved, this would break backwards compatibility. It is probably not a much-used option atthe moment, so perhaps it is fine to break it and just add it to the changelog, but we generally need to be very careful with strings in the proto-opts. I do't like breaking backward compatibility.suvsuv wrote: e) In the wk2x01.c, options for "COL Inv" should be "Normal" and "Inverted", instead of "On" and "Off"
Please Log in or Create an account to join the conversation.
- PhracturedBlue
- Offline
- Posts: 4402
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
I didn't think of the model saving issue, I am fine with it as 2x01 stuffs should be used rarely.PhracturedBlue wrote:
I agree with you, but the problem is that with the way things are saved, this would break backwards compatibility. It is probably not a much-used option atthe moment, so perhaps it is fine to break it and just add it to the changelog, but we generally need to be very careful with strings in the proto-opts. I do't like breaking backward compatibility.suvsuv wrote: e) In the wk2x01.c, options for "COL Inv" should be "Normal" and "Inverted", instead of "On" and "Off"
Please Log in or Create an account to join the conversation.
- suvsuv
- Topic Author
- Offline
- Posts: 268
I like either Standard or Generic. So please just change the selection to Standard and Advanced.PhracturedBlue wrote: 'Standard' is fine. I'll leave 'Advanced' as is.
Frankly speaking ,the “Simple” GUI is even more complex than the Advanced Mixer GUI from coding point of view
Please Log in or Create an account to join the conversation.
- Forum
- News, Announcements and Feedback
- Feedback & Questions
- PB, request for code review and merge back(2)
- Home
- Forum
- News, Announcements and Feedback
- Feedback & Questions
- PB, request for code review and merge back(2)