PB, request for code review and merge back(2)

PhracturedBlue wrote: I've merged everything that I think I'm going to for now.
Note that I changed the semantics of the negative servo-scale.

Update lang.cn and lang.tw accordingly, please have them merged to your repo

PB, since the V2.1 is released and not too much thing to do at this moment, please do a code review for the simplified GUI and decide whether you will merge it to your repo.
The codes are in bitbucket.org/sunvsuv/devil10 , and synced with your latest codes

PhracturedBlue wrote: I do plan to incorporate it, but it will take a little time for me to go through the code and see if anything needs to be changed. I'll let you know what I find as I go.

Thanks!

Following the implementation in DSX9, I refactored MIXER_UpdateTrim() to generate different tones when trims are changed, please check them out

Hi. Can you please have a look at my pull request "#28: Updated german language and make file" if you have time. It is about the MinGW environment for native Windows users someone asked me to do. I already finished it but need to polish the documentation a bit and optimize the installer so I will probably post it tommorow. But the actual make file is a bit rough with the zip program used and the only one I could find for MinGW is not used to the --move command. And the second thing is the make clean... it was not really cleaning up files in my case. But now with the MinGW environment developing with any editor you like under Windows as you can directly edit the source code and build it straight away. MinGW starts in a second and is really fast. The installer will be <150MB so that might also be interesting. Cu soon

Hi again

Can you tell me what was wrong with the make clean up?

My problem with the "old" code was that it does not delete the "objs" folder for example and if I did "make devo6" and then "make clean" it did not clean devo6 stuff e.g. because devo8 is the default target.

My intention was to really clean up all files the "make" command did to keep the source code folder "clean"

But maybe I am missong something?!

PhracturedBlue wrote: I believe I've merged everyone's code now. Please let me know if I missed anything or any issues you see.

I did not take all translations yet. I want to wait for the strings to stabilize before updates for the new 'simple' mixer

I have checked out all your update and have them updated into my repo. Everything looks great, but I have some minor changed
a) Naming the GUI to "Simple" is not good. Firstly, it will confused users with the Simple template, especially after translated into other languges. Secondly, the Simple GUI is not simple, as it can do almost everything except Program Mix(I will add support for prog mix sooner or later) and free mapping of channels. Last but not least, all commercial TXes, such as Futaba, JR and Walkera, adopt this style of GUI, which means it is Common instead of Simple. So I would suggest to rename it to ”Enhanced" and "Common", or any better names you could come up with.
b) The older model ini uses mixermode=1 , so I add backward compatibility support in the model.c
c) In the _mixer_limit.c and _throttle_hold.c, I change the range of safeval to (-120, +120). When I config my mini Vbar, I have to adjust TRVADJ to (-105, +105) in order to let the Vbar outputs from -100 to +100. As a result, setting safeval to -100 in the TX only makes the vbar's throttle ouput to -95
d) In the drexp_page.c and _drexp_page.c, allow "LIN" to be a i18n string
c) Update lang.cn and lang.tw
e) In the wk2x01.c, options for "COL Inv" should be "Normal" and "Inverted", instead of "On" and "Off"

Naming the two GUIs - taking both your arguments we should perhapse not try to describe the 2 interfaces if eventully they can do almost the same. Suggestions from my side would be naming suvsuv's version Generic or Standard and Enhanced or Alternative for the original.

Hi
I vote for : 'Standard' and 'Enhanced'
Have an happy new year!

PhracturedBlue wrote:

suvsuv wrote: e) In the wk2x01.c, options for "COL Inv" should be "Normal" and "Inverted", instead of "On" and "Off"

I agree with you, but the problem is that with the way things are saved, this would break backwards compatibility. It is probably not a much-used option atthe moment, so perhaps it is fine to break it and just add it to the changelog, but we generally need to be very careful with strings in the proto-opts. I do't like breaking backward compatibility.

I didn't think of the model saving issue, I am fine with it as 2x01 stuffs should be used rarely.

PhracturedBlue wrote: 'Standard' is fine. I'll leave 'Advanced' as is.

I like either Standard or Generic. So please just change the selection to Standard and Advanced.

Frankly speaking ,the “Simple” GUI is even more complex than the Advanced Mixer GUI from coding point of view