PB, request for code review and merge back(2)

I rewrote the whole view logic for devo10:
1) Let GUI_RefreshScreen() periodically handles refreshing of objects in a view. So the page scrolling up/down won't pile up GUI redraw events, hopefully the page crash in EXPO&DR could be fully resolved
2) Improve performance a lot for refreshing of objects in a view, by skipping objects which are not in the active viewpoint.

Above are critical updates for devo10, please review the codes and have them merged back to your repo

I found you add icon config in devo10 and I had my repo synced with it. I made the following minor changes as well:
1) In the fixed id editing, only save change when DONE is pressed
2) Allow long-press for all keys in the keyboard widget
3) Add saving tone and key-press tone in the sound.ini
4) Update lang.cn and lang.tw

BTW, when I read another thread in this forum, I want to ask you if we really need the semi-colon for all labels. In both devo8 and devo10, editable widgets can distinguish themselves from labels. Adding semi-colon for labels not only adds more different lang strings between devo8 and devo10, but also increase unnecessary size in translated lang files. If you agree, I will clear all this things from source files and langfiles

PhracturedBlue wrote: I don't want to remove the colons in this release. You may be right that they aren't needed, but I'd need to go through every page and make sure there is sufficient space for that to be true. I want to release tomorrow, and this isn't that major of an issue. we can fix it after release.

I agree with you. No hurry before this release

I） In the model_page, allow user to turn on/off telemetry scanning
2) If the telemetry is off or not supported by the protocol, the telem monitor and config pages are not usable
3) Merge common methods in the Pages.c/h into the common folder

Ok, will do it

Just check the way that wk2601 implements. It is good for GUI drawing, but it not good to save the protoopts into model ini files. Currently, you don't save the proto_opts array into the model files yet. If I save the array for devo protocol, that will be really hard to understand what the proto_opts stand for when reading a model file

PhracturedBlue wrote: After further thought, I have an elegant solution to how to savethe options properties so they are meaningful.
You don't need to update the model config code to save the properties at the moment.

I am modifying it and save the proto_opts in model files, you can continue to refactor it in you way after I check in the codes

Please review the codes

You forget to merge the pages/h under the pages/128x64x1 folder

PB, I checked in some bug fixes and changes, please review them
1) _main_page.c: 1st DMA reading is much slower then main page initialization, so the battery value is incorrect at the beginning.
2)telemetry.c: When Minicp is poweroff, it still send some invalid telemetry voltage data and trigger telem alarm , which is annoying. I disable telem alarm if the telem packet is not received for a long time
3）_model_page.c: When fixed-id is cleared, the keyboard page shouldn't show PROTOCOL_CurrentID.
4) Introduce negative servo scale to support asymmetry scale setting.
5) Make PPM's Period Frame Width configurable

PhracturedBlue wrote: 1) This should have been fixed by d66713fda604. Do you actually need the change still?
3) This is done on purpose. It is the only way for a user to see the random ID that was used, and was specifically requested by the DSM2 folks I think.

d66713fda604 doesn't work in Devo10. Each time during reboot, devo10 shows incorrect voltage, e.g. 0.42v, untill 2-3 seconds later. So I would rather to hide the incorrect voltage display until it is ok.

3) If it is specificlly for dsm2, we should do it on for dsm2. In devo protocol, it doesn't make sense to ask user to delete the Protocol_ID first when switching from Non-fixedid to Fixed id