How works new switches toggle icons in 128x64x1?

Since the 'Enable Multiple Icons per switch' commit (#a2c0786)...
I do no more understand how works the switches icon...
For exemple if I choose the 13th icon (TH white on black) of the following image for the RUD D/R of my Devo10 I will see the 12th ( F^) if the RUD D/R is Off and the 1th (TH Black on White) if RUD D/R is On...
What is the logic, if it is ?



I though that this new feature did'nt affect the 128x64x1 screens?
After editing the modelx.ini. I see :
toggle1=RUD DR
tglico1=12,1,0

So now I understand a little bit more. Read seems to be OK but record is bad....

Ok thanks PB

As Gloria Gaynor said




So yes the main menu seems to work properly..
I made a few flights this afternoon,every think was ok.

I don't know if it's due to the #a2c0786 commit or before, but
now,in the mixer menu (Advanced), when we choose <Complexe>,
The first entries are Src, Curve, Scale and then (only) #Mixers and Page ....
I think that it's much more better to have #Mixers and Page on top.
(this is ok on the Devo8).

This was probably introduced in the rev 364a05 of file pages/common/advanced/_mixer_setup.c

enum {
COMMON_SRC,
COMMON_CURVE,
COMMON_SCALE,
COMMON_LAST,
};
enum {
COMPLEX_MIXER = COMMON_LAST,
COMPLEX_PAGE,
COMPLEX_SWITCH,
COMPLEX_MUX,
COMPLEX_OFFSET,
COMPLEX_TRIM,
COMPLEX_LAST,
};

PhracturedBlue wrote: I just checked in the switch selection code. It is only tested via the emulator, but it appears to be functional.

Hi PB
I've just tested (via emulator) the new switch icon setup page...But I'm not able (or don't known how) to toggle between the 1 and 0. Even if I toggle the real switch I always change the first 0 state?
The setup FMODE switch has 3 states 0, 1 and ... 0 ?
Thank to have reorder the mixer setup page.

Hi,
OK I've understand how it works.. First we have to use the LEFT/RIGHT button to highlight and select the switch position, then use again the LEFT/RIGHT button to select the desired icon, etc ... etc ...
So in fact It works well...
Thanks.

It looks good in the emu_devo10 (only the state "2" is labelled "0", as Domcars0 mentioned).
From my point of view the selection page is a little bit confusing because the selected icons on the left and the selectable icons are not divided enough.
My solution for 320-screen left place for four lines with 8 icons each, for 128-screen there are 4 lines with 9 icons each. Maybe it would be better to make this uniform and place only 8 icons in a line? So the selected icons could be seperated easier.

I think that the 'gray' image is not drawn on the select icon page ... So , once we have selected an icon, it's not more possible to choose the 'none' (gray) .. one?
Or may we have to add the gray in the switches.bmp image ?

If I add a 'gray' (in fact white ) icon in the switches.bmp, I do not need the gray.bmp file ... and everything works well ...
Here is what I have in my modelx.ini file (after configured via the
setting page)

toggle1=FMODE
tglico1=27,6,7

And here is my (new) switches.bmp (take care there is a white icon at the end of the file, the 27th! You can't see it on the below view )




It seems that we do not need gray.bmp with 128x64x1 screen?

Houps.. sorry I made a mistake (again? I know, I know ) ...
In fact when we select a switch position (to assign an icon to).. it toggle
to none (gray) .. we may leave it at this if we do not want an icon for this
position ...
But may be the code will be lighter whithout the gray.bmp file ?
Or may we have to keep it for the Devo6/8/12 compatibility?

I still haven't found time to look deeper in th new code so I hope I don't tell nonsens...
I introduced the GRAY.BMP because I had to paint a box to click on in Devo8. This is the way the actual switch position (which will get the next selected icon) is changed. And this did not work with an empty box because I found no way to assign a callback function.
This seems not really necessary in Devo10 because the icons don't need a callback function (all controlled by the keys).
We could completely going without gray.bmp/special icon if there would be another way of creating a display area where I can click on (e.g. use the label instead; define a special image which is fully transparent; I tried to cut the piece of the background image for the icon to make it invisible - was not really nice, worked, but did not show the empty position...).

So,
It seems that the new switches toggle icons works well on the real Devo10 ...
but PB don't forget to give the gray.bmp in the devo10 filesystem, without it
(and if there is no 'gray' icon to choose in the switches.bmp) the displayed icons are not the good one.
Thank to you and to rbe2012.