devo 12 wide screen...

PhracturedBlue wrote: As I mentioned earlier, I think the logic may be tricky. The problem with the current code is if I want to change the top box in a column from a toggle to a box, I lose everything underneath. So now I need to build the columns top to bottom.

I can not reproduce this. Only when an element moves out of the screen while toggling the top element it looses its properties.

I think you probably need to save the starting values of the lower boxes while cycling through the above boxes. You can then either treat it as empty or use its starting value depending on how it packs. Once the user switches to a different element, its value gets fixed.

So if the 5th row is a 'cross', all other rows are 'None', and I cycle the top row, the 5th row would show as:
small-box: cross
big-box: none??? (today it becomes a big empty space),

No, the big-box is the forth element because for the fifth there will not be enough space

toggle: none (this is how it is now)

This is what I mean. When an element is shifted off the screen its ifnomation is lost.

small-bars: none
big-bars: none
small-box: cross (this is the important difference)

This is really tricky. I can store the properties of any elements if they are visible or not (this is what I have done all the time until this morning), but I may not count them - otherwise an invisible icon will prevent other elements to change their type to icon (because we already have one and a second is prohibited). I can easily roll this back but the problem with the counted icon reappears. I will think about a different solution.

but if I switch to a different element at any time whatever all values in the column become permanent.

When I think about it it seems to me that things would be easier when only one empty element per row is shown (at the lowest place). This would result in a start screen (nothing configured) where in every column there is one light green small box with source "None" (= empty element). When I change its type or its source (a real box instead of a placeholder for an empty element) a new one appears if it will fit.
What do you think about this?
The problem that changing one of the upper elements can throw some lower off the screen will stay, but it would be easier to store the values when I know there can only be one empty element per column.

The above mentioned single empty element would be called "empty". And if an element type is changes to empty on the left can appear a button to allow to delete it.

Type Change is fixed
Toggle Settings are to Do

I try to be disciplined and create issues for every problem mentioned here (aside these which are discussed) so you can follow them at bitbucket.

Wene001 wrote: Type Change is fixed
Toggle Settings are to Do

PhracturedBlue wrote: I would not expect this situation to be possible since you are turninghidden items to 'None'

You are right, this shouldn't happen anymore. Maybe I will find some time in the later evening...

I have again uploaded a new version. I did not have much time for testing but the behavior PB mentioned is gone.
Now it's basketball time for me

Hi guys,
I have fixed the toggle icon selection issue. Now for all toggle boxes the correct icons and sources are shown and used.

I have done some improvement to the crosses (they disappeared when a safety dialog was shown; probably also when a telemetry alarm occurs). The crosses are now redrawn after a second if their values do not change. This leads to only a little number of unwanted redraws (max. 2 per second).
I am not happy with this but I did not find a better solution.
One possible thing would be not to fill the crosses background (leave them transparent as the trims are) so drawing the frame and the few lines could be done fast enough to prevent the screen from flickering.
I try to implement this tomorrow so we can compare both ways. But I would highly appreciate a test with a real Devo12 because I have no feeling if it is ok like it is or not.

Tested on Devo 12s
For me its ok like it is.
redraw is not noticeable.

Found a bug:
When i select the source for the Toggle Icons:
stepping forward "RUD DR" is missing
stepping backwards "RUD DR" is between "AUX7" and "ELE DR"

After pressing "OK" at Icon Select page it would be nice to have the settings of the Toggle box on the left. Not to have to click on the Toggle box again for each Icon select.

Thank you.
The first error was a bug deviation had earlier - I thought I provided a fix for this... I will look again.
The second (toggle focus) I will improve.

hello rbe
please can you merge PBs Code with your repo, that we have the ppm in working and widescreen.
if the bottom alignment would work after rebooting tx too, then it would be perfekt.

"Well, I'll do my very best, Miss Sophie..."

Thanks to all for the positive feedback. I am not all around glad with my solution but it can be a good starting point.
I will try to make the improvements later today, but not sure if the time will suffice.
I'll keep you informed.

Wene001 wrote: ...source for the Toggle Icons:
stepping forward "RUD DR" is missing

Fixed this. Originally issue #314 and corrected, but I copied the old code...

Wene001 wrote: After pressing "OK" at Icon Select page it would be nice to have the settings of the Toggle box on the left. Not to have to click on the Toggle box again for each Icon select.

It is done, also for the model icon.
Found a bug when displaying the toggle icon select page (wonder why this never happened before that the page was not opened (internally a wrong index letting the program assume that there was no input selected)).

I pushed a new version.

Wene001 wrote: if the bottom alignment would work after rebooting tx too, then it would be perfekt.

It does now. New version pushed.

admiral schneider !
ppm in please from PBs repo and i´ll give it a try

i`ve added 4 lines of code to your model.c to bugfix the PPMin like it was documented in PBs Repo. Changed some other files.
Now i`ve the best Firmware on my Devo12 inkl Widescreen and PPMin

Thanks to all

I have committed a version (about an hour ago) which was merged with PBs repo (from today morning, commit b8bd2b3).

I am working to get PPM in working for the crosses but this can be heavy due to my known lack of Devo12 - testing is not easy.

Can you tell me about the lines you changed (and the "other files")? Is this still necessary after I have merged PBs repo into mine? If yes I will include your fixes.

Wene, I am happy when you are.

bitbucket.org/PhracturedBlue/deviation/c...9e62830c02990c8cfb1a
Above is the code that i added to your model.c
i think if you have merged with b8bd2b then you have all the changes i made

it would be nice to see action on the bars of the mainscreen if we switch to the slave in trainer mode, like we could see it on the channel page.

If i configure PPMin to the mixer, all is fine, and i can see it on the bars of the mainscreen

I had some struggle with allowing PPM inputs as sources for crosses, but I think I am ready with this now.
As always I can only test in the emulator and there are no PPM inputs available so I do not know if it will work.
Wene, if you want to test: I had to change a lot to allow two sources for crosses (earlier: selecting a stick defined both sources, now they are independent). Maybe other things belonging to the crosses are mixed up again although it looks good in the emulator.

Wene001 wrote: it would be nice to see action on the bars of the mainscreen if we switch to the slave in trainer mode, like we could see it on the channel page.

This is a feature deviation does not bring with. I think when this shall be implemented it makes more sense to do that independent from the advanced widescreen gui. I played today for the first time with the trainer mode and I am also not happy when only the channel monitor shows the inputs (but for Devo12 now you have crosses ).
Perhaps I should implement the crosses for the Devo8 gui? This could be a side effect to make a three-column-version as PB proposed which should then be able to run on a Devo8/6 too. But I do not know yet how much time this will take.