1. Forum
  3. Development
  5. Development
  7. PB's newgui

PB's newgui

More
24 Jun 2013 03:56 #11286 by Pattaya01
Replied by Pattaya01 on topic PB's newgui
I do my best. You fix them faster then I can find them :lol:

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 04:31 #11287 by Pattaya01
Replied by Pattaya01 on topic PB's newgui
I love it.... Nice and clean, got the info I want, where I want.


I will keep on playing, but for now, don't see bugs.
Attachments:

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 04:38 - 24 Jun 2013 05:00 #11288 by vlad_vy
Replied by vlad_vy on topic PB's newgui
1) PB, can you increase space between 'scroll box' and 'Delete' button at object config pages? They are too close.

2) Also, it's not obvious how to exit after selection 'Quick Page', by 'Cancel' button???

3) Button Monitor - 'Touch to Lock' is mixed with remainder from 'Touch to Unlock'. For my liking will be better if 'Touch to Lock/Unlock' will be black font.
Last edit: 24 Jun 2013 05:00 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 05:07 #11289 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

vlad_vy wrote: 1) PB, can you increase space between 'scroll box' and 'Delete' button at object config pages? They are too close.

I fixed this.

2) Also, it's not obvious how to exit after selection 'Quick Page', by 'Cancel' button???

'Close' would be better, but the dialog doesn't allow changing the button text. There are other things I can do though. I'll work on it.

3) Button Monitor - 'Touch to Lock' is mixed with remainder from 'Touch to Unlock'. For my liking will be better if 'Touch to Lock/Unlock' will be black font.

Fixed

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 05:27 - 24 Jun 2013 05:46 #11291 by vlad_vy
Replied by vlad_vy on topic PB's newgui
1) USB page - bold font has not UNICODE support, all translated text is missing.



2) Transmitter config - can you make touch screen 'Test' button as small as possible? Russian 'Calibrate' word doesn't fit in button and moved to the left and cutted from the right.

Attachments:
Last edit: 24 Jun 2013 05:46 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 06:17 #11294 by Kdean
Replied by Kdean on topic PB's newgui
Yeeaaay, time to make some templates.

Please Log in or Create an account to join the conversation.

  • rbe2012
  • rbe2012's Avatar
  • Offline
  • So much to do, so little time...
More
24 Jun 2013 06:58 - 24 Jun 2013 07:55 #11295 by rbe2012
Replied by rbe2012 on topic PB's newgui
1) Sorry, my fault. I have seen that the big font used in large boxes does not have all characters, but I did not expected this for the bold font. We should simply use the non-bold font.
2) with these changes (line 79-81 in pages/320x240x16/tx_configure.c):
#define BUTTON_TEST  BUTTON_32x16
        #define BUTTON_TOUCH BUTTON_64x16
        #define COL2TEST     (COL2+64)
it looks like this:


This is the best we can achieve with the existing button sizes. But in some other languages (Spain, German, the Asian character sets) the word for "Test" is longer so this does not fit...
Maybe we should let the test button as big as it is now and move it a few pixels right... or in a second line... or we remove the test screen (I have never understood for what it could be useful besides development).
Attachments:
Last edit: 24 Jun 2013 07:55 by rbe2012.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 07:10 #11296 by vlad_vy
Replied by vlad_vy on topic PB's newgui
I think touch screen 'Test' can be removed, I don't use it at all. Or it can be the second step for touch screen calibration, without dedicated button.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 08:19 #11297 by Kdean
Replied by Kdean on topic PB's newgui
Im not sure if this is something that can be changed by PB, but i noticed that the telemetry alarms do not trigger a red box on the display. Like when a countdown time has reached its target the alarm sounds and the box will become red. This would be very helpfull in finding out exactly what sensor is sounding the alarm.

Please Log in or Create an account to join the conversation.

  • rbe2012
  • rbe2012's Avatar
  • Offline
  • So much to do, so little time...
More
24 Jun 2013 09:14 #11299 by rbe2012
Replied by rbe2012 on topic PB's newgui

ave1 wrote: button monitor indication/feedback might not be as desired


Oops, you're right. I reordered the buttons, but not the values. This can be corrected with
GUI_CreateLabelBox(&gui->value[reorder[i]], 10 + X_STEP * (i % 3), y, 16, 16,
                         &SMALLBOX_FONT, NULL, NULL, (void *)"");
        GUI_CreateLabelBox(&gui->chan[reorder[i]], 30 + X_STEP * (i % 3), y+2, 0, 0,
                &DEFAULT_FONT, button_str_cb, NULL, (void *)(long)reorder[i]);
(line 166-169 in pages/320x240x16/chantest_page.c)

Please Log in or Create an account to join the conversation.

  • rbe2012
  • rbe2012's Avatar
  • Offline
  • So much to do, so little time...
More
24 Jun 2013 09:45 - 24 Jun 2013 10:14 #11300 by rbe2012
Replied by rbe2012 on topic PB's newgui

Pattaya01 wrote: OK, got you. I have done that, and there are more toggles now. So when I want to assign pictures to the toggles, a side bar appears (before the toggles fit in the screen) which I can use to scroll down. But this happens:



It works fine, it's just a cosmetic issue.


I am not able to confirm this. For me both emus (devo8+12) work as expected; esp. the scroll bar is at the right side.
Tested with the actual version (21034f).

EDIT: the screen look strange - as if the 320x240 resolution is used... This happened only with former versions. I will look at the 320-screen again to see if this overlapping happens there...
EDIT2: no, everything fine. The top of the scroll bar is under the first row.

HINT: you should put your own toggle icons in toggle3.bmp. toggle0-2.bmp are reserved for the default toggle icons, toggle3.bmp is for user specific toggles...
Last edit: 24 Jun 2013 10:14 by rbe2012.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 10:55 #11301 by FDR
Replied by FDR on topic PB's newgui

PhracturedBlue wrote:

FDR wrote: 11. Could the long mouse press select the element before opening the popup, when we press on a deselected one?

I have changed it. However, the reason I did it this way originally is because it canbe difficult to accurately select an object with the touchpad, so this way you could quick-press until you got the right one, and then long-press to edit it. Le me know which way you prefer.

I don't want to be ungrateful, but could you redraw the screen before opening the dialog, so the new selection could become visible too? ;)
The selection changes after I close the dialog, however it is a bit confusing, that the dialog shows other options, than the selection would suppose...

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 14:36 #11302 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

vlad_vy wrote: I think touch screen 'Test' can be removed, I don't use it at all. Or it can be the second step for touch screen calibration, without dedicated button.

Fixed now

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 14:37 #11303 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

rbe2012 wrote:

ave1 wrote: button monitor indication/feedback might not be as desired


Oops, you're right. I reordered the buttons, but not the values. This can be corrected with
GUI_CreateLabelBox(&gui->value[reorder[i]], 10 + X_STEP * (i % 3), y, 16, 16,
                         &SMALLBOX_FONT, NULL, NULL, (void *)"");
        GUI_CreateLabelBox(&gui->chan[reorder[i]], 30 + X_STEP * (i % 3), y+2, 0, 0,
                &DEFAULT_FONT, button_str_cb, NULL, (void *)(long)reorder[i]);
(line 166-169 in pages/320x240x16/chantest_page.c)

Fixed

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 14:58 - 24 Jun 2013 14:59 #11304 by vlad_vy
Replied by vlad_vy on topic PB's newgui
Without any specific idea, to fill screen only.

Attachments:
Last edit: 24 Jun 2013 14:59 by vlad_vy.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 15:08 #11305 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

vlad_vy wrote: 1) USB page - bold font has not UNICODE support, all translated text is missing.

Fixed

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 19:20 #11310 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

FDR wrote: I don't want to be ungrateful, but could you redraw the screen before opening the dialog, so the new selection could become visible too? ;)
The selection changes after I close the dialog, however it is a bit confusing, that the dialog shows other options, than the selection would suppose...

Fixed. I now select on press rather than release

vlad_vy wrote: 2) Also, it's not obvious how to exit after selection 'Quick Page', by 'Cancel' button???

Switched back to 'Ok' which now makes more sense I think with this layout.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 19:36 #11311 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

Kdean wrote: Im not sure if this is something that can be changed by PB, but i noticed that the telemetry alarms do not trigger a red box on the display. Like when a countdown time has reached its target the alarm sounds and the box will become red. This would be very helpfull in finding out exactly what sensor is sounding the alarm.

Not really relevant to the gui rework, but I implemented this too. It is untested at the moment though.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 19:42 #11312 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui
I think the code has stabilized well enough that it is time to merge it into the mainline. That also means it should be safe enough to try on your Tx now. I won't be doing dfu builds for it until it is merged though.

If anyone has any concerns, let me know.

Please Log in or Create an account to join the conversation.

More
24 Jun 2013 19:44 #11313 by PhracturedBlue
Replied by PhracturedBlue on topic PB's newgui

vlad_vy wrote: Without any specific idea, to fill screen only.

It looks nice, and if you provide the ini file, I'll add it to the templates, but the default should be for the most-common setup:
6 channels and no telemetry

Please Log in or Create an account to join the conversation.

  1. Forum
  3. Development
  5. Development
  7. PB's newgui
Time to create page: 0.201 seconds
Powered by Kunena Forum
Force desktop display