Devo 10/7E small UI (updated 1st post)

More
28 Jan 2014 17:35 #19334 by linux-user
Replied by linux-user on topic Devo 10/7E small UI (work in progress)
Hi,

I did compare the small-config with the "official" nightly and found the following differeces:

1.) in Main Page USB is missing.
2.) in Mixer page (see attached pics) the header is called channnel instead of mixer.
3.) in mixer page (see attached pics) you don't show asigned switches.
Is this intentional?
Attachments:

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 17:35 #19335 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
I fixed 2 more issues:

1. Layout load no header (issue #494 on BitBucket)
2. Main page config no header on 7E ("long ENT message" only shown on Devo 10). Added "Main page config" as header.

Both pushed to repo.

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 17:37 - 28 Jan 2014 17:43 #19336 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
1. USB was removed by PB

2 & 3 are both intentional the mixer page is rewritten (mostly) and traded off switches for more lines.

On 2&3 I need more opinions. I like it this way but I'll not be affected by changes since I run my own customized version of Deviation anyway :)


Edit: fixed mixer page title.

linux-user wrote: Hi,

I did compare the small-config with the "official" nightly and found the following differeces:

1.) in Main Page USB is missing.
2.) in Mixer page (see attached pics) the header is called channnel instead of mixer.
3.) in mixer page (see attached pics) you don't show asigned switches.
Is this intentional?


Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire
Last edit: 28 Jan 2014 17:43 by sbstnp.

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 18:20 - 28 Jan 2014 18:24 #19337 by WheresWaldo
Replied by WheresWaldo on topic Devo 10/7E small UI (work in progress)
Don't know what did it, but standard mixer is back. Language selection is still messed up, no accented characters in the selection screen, make for some odd visible choices, also two languages seem to be blank spaces.

Attachments:
Last edit: 28 Jan 2014 18:24 by WheresWaldo.

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 18:29 - 28 Jan 2014 18:33 #19338 by linux-user
Replied by linux-user on topic Devo 10/7E small UI (work in progress)

sbstnp wrote: 2 & 3 are both intentional the mixer page is rewritten (mostly) and traded off switches for more lines.

I like it with more lines as it is.


Edit: fixed mixer page title.

How about a title like this?:
Channel - Mixer - Src

How about adding more lines in the mixer-config-page (see pic)?
There, the spinbox and their name would often fit on the same line.
But maybe that is not easily possible.

Attachments:
Last edit: 28 Jan 2014 18:33 by linux-user.

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 18:33 #19339 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)

WheresWaldo wrote: Don't know what did it, but standard mixer is back. Language selection is still messed up, no accented characters in the selection screen, make for some odd visible choices, also two languages seem to be blank spaces.


04b03 font doesn't have any accented chars. They can be patched in but I haven't tried yet and do not know if they will fit the current font height.

My target is to have this working for English at first.

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
28 Jan 2014 18:36 #19340 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
Channel - Mixer - Src won't fit the large UI.

More lines is possible but again it won't fit the larger UI. If I ever decide to go for a small only fork, then yes it will happen.

I'm trying to meet PB's expectations here.

linux-user wrote:

sbstnp wrote: 2 & 3 are both intentional the mixer page is rewritten (mostly) and traded off switches for more lines.

I like it with more lines as it is.


Edit: fixed mixer page title.

How about a title like this?:
Channel - Mixer - Src

How about adding more lines in the mixer-config-page (see pic)?
There, the spinbox and their name would often fit on the same line.
But maybe that is not easily possible.


Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 02:15 #19357 by PhracturedBlue
Replied by PhracturedBlue on topic Devo 10/7E small UI (work in progress)
I reviewed all the patches, and am happy with them. God job!

The changes are I've created a temporary fork for my integration purposes here:
bitbucket.org/PhracturedBlue/deviation-smallui

it is identical to your repo except for changes to the chan_page.c you (probably accidently) reverted.

Note you can't merge from it since I actually applied the changes file-by-file as I reviewed them, and didn't pull your repo into mine.

I only see one issue that would prevent me from merging this:

Original:


Small GUI:


The Small GUI looks worse with all the widgets jammed together and no space between them. I haven't looked at the options to deal with this yet, but it definitely needs to be dealt with.
Attachments:

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 03:50 - 29 Jan 2014 04:24 #19358 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
Fixed that and some more.

I had to introduce 2 new params:

'line_space' is now absolute line height
'header_widget_height' to prevent overpainting of header button on headers. smaller than 'header_height'
'line_height' is now text height.

This basically makes the large UI behave almost like before.




The small UI as defined currently (8 lines displayed) is packed together unfortunately. People can reduce the number of line from 8 to 7 and have some air between widgets if they choose so.

A 7 line small UI would look like:
header_height=10
header_widget_height=8 (or 9)
line_space=9
line_height=8

Edit:
Fixed some mixer setup page issues too.

Edit2:
Played for a few minutes with the 7 line UI and I think it looks better than the 8 line. 6 lines of actual content + 1 line page header is definitely not bad. Still, I think I need to align the widget text to bottom rather than top.





Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire
Attachments:
Last edit: 29 Jan 2014 04:24 by sbstnp.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 05:05 #19361 by PhracturedBlue
Replied by PhracturedBlue on topic Devo 10/7E small UI (work in progress)
Looks good. I'll likely merge this in soon. I'm 312bytes over on the devo7e build (using my old 4.6 compiler). I'm going to spend a bit of time to see if I can get this to build on 4.6 before giving up and moving to 4.8.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 06:51 #19364 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
Thanks!

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 08:54 - 29 Jan 2014 08:55 #19367 by linux-user
Replied by linux-user on topic Devo 10/7E small UI (work in progress)
Hi,
found minor issues:
1.) with large UI invertet values on main page are not fully displayed.


2.) in small UI the boxes in telemetry monitor do not look very pretty
I think those boxes aren't very helpful on lowres display and telemetry monitor is the only place I saw them anyway.

Attachments:
Last edit: 29 Jan 2014 08:55 by linux-user.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 09:09 - 29 Jan 2014 09:09 #19368 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
(1) can be solved by either replacing 5x7 font with 04b03 or incresing the height of the smallbox to 10 (from 9). My label changes impacted that.

(2) Agree, lets hear PB's opinion on this.

linux-user wrote: Hi,
found minor issues:
1.) with large UI invertet values on main page are not fully displayed.



2.) in small UI the boxes in telemetry monitor do not look very pretty
I think those boxes aren't very helpful on lowres display and telemetry monitor is the only place I saw them anyway.


Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire
Last edit: 29 Jan 2014 09:09 by sbstnp.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 14:05 - 29 Jan 2014 14:08 #19374 by WheresWaldo
Replied by WheresWaldo on topic Devo 10/7E small UI (work in progress)

sbstnp wrote:


Using 7 lines for data output does make it similar to the default Taranis screen which also uses a header line and 7 data lines.

Using 7 lines in the telemetry screen would likely give you similar results without much hassle, it looks like it is set up for 8 field lines.
Last edit: 29 Jan 2014 14:08 by WheresWaldo.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 14:49 #19378 by PhracturedBlue
Replied by PhracturedBlue on topic Devo 10/7E small UI (work in progress)

sbstnp wrote: (1) can be solved by either replacing 5x7 font with 04b03 or incresing the height of the smallbox to 10 (from 9). My label changes impacted that.

Let's change the smallbox size then. I don't wantto use the tiny font for the smallbox. Maybe we should set the smallbox/bigbox size based on the font used instead.

I still like the boxes on the large-gui page. We could probably gve them a custom font so that you can turn them off on the small-gui though.

Please Log in or Create an account to join the conversation.

More
29 Jan 2014 15:08 #19382 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
It looks all right at 10px. Changes pushed.

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
01 Feb 2014 21:33 #19630 by PhracturedBlue
Replied by PhracturedBlue on topic Devo 10/7E small UI (work in progress)
I optimized the model parser/writer code. The changes are significant, and definitely need some thorough testing, but it is enough to basically reclaim the space that the small UI code consumes.
I'm going to let those changes stew, and make sure it works as intended, then I'll pull this code in.

Please Log in or Create an account to join the conversation.

More
02 Feb 2014 04:58 #19670 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
Definitely seeing bugs: change TX power, lose channels/mixer settings.

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

More
02 Feb 2014 06:00 #19674 by PhracturedBlue
Replied by PhracturedBlue on topic Devo 10/7E small UI (work in progress)
Thanks, I forgot to test after a last minute optimization, and of course I screwed it up. Let me know if you continue to see issues.

Please Log in or Create an account to join the conversation.

More
02 Feb 2014 06:07 #19677 by sbstnp
Replied by sbstnp on topic Devo 10/7E small UI (work in progress)
Will do, thanks

Devo 10 + 4in1
Spektrum Dx9
FrSky Taranis + TBS Crossfire

Please Log in or Create an account to join the conversation.

Time to create page: 0.286 seconds
Powered by Kunena Forum