Channel reorder testing

PhracturedBlue
Topic Author
Offline

26 Jan 2014 17:22 #19181 by PhracturedBlue

Channel reorder testing was created by PhracturedBlue

Due to popular demand, I've implemented channel reordering when switching protocols. We've tried this before without great success, but I'm committed to making it work this time. But it can only be done with your help. I've updated the nightlies with the latest code changes. I now need to know what doesn't work as expected. this only impacts the advanced mixer. There is no huge rush, as there are no plans for the next Deviation release at this time, but this feature will only be as good as the testing it gets.

Please Log in or Create an account to join the conversation.

HappyHarry
Offline

26 Jan 2014 18:03 - 26 Jan 2014 18:06 #19185 by HappyHarry

Replied by HappyHarry on topic Channel reorder testing

from a quick test on my 7e, in mode2, with heli as the model type, and only checking the output via the channel monitor screen

dsm and dsmx look correct, with their mappings being changed to the correct positions.

devo is fine, again the mappings being changed to the correct positions.

hisky, there is a problem with hisky, when choosing hisky the channel mapping goes

1 ailerons (right stick l/r)
2 no response at all
3 elevator (right stick u/d)
4 rudder (left stick l/r)
6 responds to pitch/throttle (left stick u/d)

hubsan, again a problem,

1 no response at all
2 ailerons
3 elevator
4 rudder
6 throttle/pitch

i haven't checked other protocols as i'm not 100% on what their mappings should be

Last edit: 26 Jan 2014 18:06 by HappyHarry.

Please Log in or Create an account to join the conversation.

VTdev
Offline

26 Jan 2014 18:24 #19189 by VTdev

Replied by VTdev on topic Channel reorder testing

I'd be happy to test, if you want.

Please Log in or Create an account to join the conversation.

HappyHarry
Offline

26 Jan 2014 18:54 - 26 Jan 2014 18:55 #19190 by HappyHarry

Replied by HappyHarry on topic Channel reorder testing

pb has said many times that all testing is gladly recieved

, if it's a 7e you have then you can install the build from this post here >> www.deviationtx.com/forum/builds/2661-7e...timer-weekly-updates

if not you can wait foe the nightly build for tonight and install that. or if you know how to compile from source you can head over to pb's repo and build it yourself >> bitbucket.org/PhracturedBlue/deviation

Last edit: 26 Jan 2014 18:55 by HappyHarry.

Please Log in or Create an account to join the conversation.

PhracturedBlue
Topic Author
Offline

26 Jan 2014 19:04 #19192 by PhracturedBlue

Replied by PhracturedBlue on topic Channel reorder testing

I regenerated the nightlies already for all Tx.

If you find issues, the easiest thing to do is post a working model and one that was converted that doesn't work. I can then compare and see what isn't mapping as expected.

Please Log in or Create an account to join the conversation.

VTdev
Offline

27 Jan 2014 01:57 #19251 by VTdev

Replied by VTdev on topic Channel reorder testing

I was able to test after Harry straightened out my installation method.

I tested a plane model in DSM2. Everything worked as expected re. modes and channels.

I checked that the Tx warned of THR stick above -100 on startup, which it did correctly.

One minor detail didn't work as it had in the past -- the throttle % on the main display was set to CH3 so showed elevator movement instead of throttle.

This is reflected in a setting in the model.ini. Changing that to CH1 restored the throttle % display.

I'll try to test dual rates and expo, etc in the mixer when I can.

It looks good so far!

Please Log in or Create an account to join the conversation.

rbe2012
Offline
So much to do, so little time...

27 Jan 2014 06:16 #19259 by rbe2012

Replied by rbe2012 on topic Channel reorder testing

Should we have something like "THR=ch3" / "THR=ch1" in the main layout and timer page? The channel could change with the protocol, but the value displayed would be the one intended to see.

Please Log in or Create an account to join the conversation.

FDR
Offline

27 Jan 2014 06:58 #19260 by FDR

Replied by FDR on topic Channel reorder testing

Yep, this would be like the feature I asked for, which I called aliases...

www.deviationtx.com/forum/7-development/...lease-3-1-0?start=80

Please Log in or Create an account to join the conversation.

stevecox
Offline
Keep swinging

27 Jan 2014 09:32 #19263 by stevecox

Replied by stevecox on topic Channel reorder testing

If there were a vote for aliases +1 from me

Adelaide

Please Log in or Create an account to join the conversation.

PhracturedBlue
Topic Author
Offline

27 Jan 2014 14:46 #19272 by PhracturedBlue

Replied by PhracturedBlue on topic Channel reorder testing

why does it need to be so complicated? I can just remap the display at the same time I remap the channels. I think that would be sufficient. Or am I missing something?

Please Log in or Create an account to join the conversation.

rbe2012
Offline
So much to do, so little time...

27 Jan 2014 14:58 #19274 by rbe2012

Replied by rbe2012 on topic Channel reorder testing

Display and timer trigger and complex mixer inputs...

Please Log in or Create an account to join the conversation.

PhracturedBlue
Topic Author
Offline

27 Jan 2014 15:14 #19276 by PhracturedBlue

Replied by PhracturedBlue on topic Channel reorder testing

the mixers are the only tricky ones to deal with I think. In all other cases, there is a single source, and it is either connected to an input or output. In the case of an output you remap it. But you are right that there are other variables in the model structure to deal with.

Please Log in or Create an account to join the conversation.

FDR
Offline

27 Jan 2014 15:35 #19277 by FDR

Replied by FDR on topic Channel reorder testing

To name a few places:
- mixer sources (both real and virtual);
- mixer switches (both real and virtual);
- timer switches;
- timer reset switches;
- timer proportional values;
- main page box sources;
- main page bar sources;
- datalog channels.

Did I forget some?

Please Log in or Create an account to join the conversation.

HappyHarry
Offline

27 Jan 2014 15:42 #19279 by HappyHarry

Replied by HappyHarry on topic Channel reorder testing

surely when setting up a model choosing the model type, protocol and GUI style is the first thing you do, so surely none of those would be set up?

as I don't think changing protocols mid life of a model is a very common use case?

Please Log in or Create an account to join the conversation.

IMback!
Offline

27 Jan 2014 15:47 #19280 by IMback!

Replied by IMback! on topic Channel reorder testing

Not very common, but it happens. I swaped a skyartec board into a super cp that caused a protocol switch mid life.

Please Log in or Create an account to join the conversation.

HappyHarry
Offline

27 Jan 2014 16:04 #19281 by HappyHarry

Replied by HappyHarry on topic Channel reorder testing

yeah true enough, but how many of these corner use cases should be dealt with automatically?

personally I think if the channel mapping works when done at initial model setup that should be a good enough target, but with my current c/c++ coding skills I'm not quite up to submitting code yet, so my opionion should be taken with that in mind lol

Please Log in or Create an account to join the conversation.

FDR
Offline

27 Jan 2014 16:07 - 27 Jan 2014 16:09 #19282 by FDR

Replied by FDR on topic Channel reorder testing

...and you can replace a standard receiver anytime with an other maker's one, so you might need to switch protocols too...

EDIT: Actually I found myself in this situation, because I want to replace one DEVO rx of mine with an OrangeRX...

Last edit: 27 Jan 2014 16:09 by FDR.

Please Log in or Create an account to join the conversation.

rbe2012
Offline
So much to do, so little time...

27 Jan 2014 16:48 #19284 by rbe2012

Replied by rbe2012 on topic Channel reorder testing

Imagine copying a model's setup for another heli (to have a well known start position) and change the protocol afterwards (like using a Devo V100d08 config for a Blade mCP-X). You might have to address all points listed by FDR above.

Please Log in or Create an account to join the conversation.

PhracturedBlue
Topic Author
Offline

27 Jan 2014 17:01 #19286 by PhracturedBlue

Replied by PhracturedBlue on topic Channel reorder testing

you missed the safety switches.
I'll need to look at the mixer mapping again, but getting that to work in a predictable way was tricky the 1st time. I'm hoping I don't need to muck with it too much.
The others are all straight forward.

Please Log in or Create an account to join the conversation.