Source code bug report about DEVO7E binding....

As I metioned in the topic : www.deviationtx.com/forum/3-feedback-que...e6b-zip-doesn-t-work

DEVO7E seems something wrong about binding when use FIXID...

These days, I'm writing a Chinese Version for DEVO7E, the whole GUI is rewritten to reduce size, and the protocols is porting from PhracturedBlue's Deviation source.

When porting to devo.c (located at src\protocol), I found there may be a writing mistake:




I thought the code means when Model.fixed_id is zero, the tx will generate a random id and use_fixed_id will be zero (clear by initialize line 507), but when Model.fixed is set, use_fixed_id should be no-zero.

And there is another place make me confuse... function bind() line 491, is it mean whatever the Model.fixed is, the use_fixed_id is always 1?

Hope for answer~

here is some snapshot about the Chinese firmware, is there anybody can give me a Traditional Chinese 12dot font file? If has pls send to This email address is being protected from spambots. You need JavaScript enabled to view it.

Devo7e can open chinese language？Can you give me a chinese deviation，Thank you！

try to clarify your confusion:
"And there is another place make me confuse... function bind() line 491, is it mean whatever the Model.fixed is, the use_fixed_id is always 1?"

if (PROTOCOL_AutoBindEnabled())
PROTOCOL_Init(0);
else
PROTOCOL_Bind();


and
case PROTOCMD_CHECK_AUTOBIND: return Model.fixed_id ? 0 : (void *)1L;

So which means bind function is only called whenever Model.fixed_id != 0

"but when Model.fixed is set, use_fixed_id should be no-zero."
It probably does not matter (though it is worth to make clear) for the value to be set here because bind function will set it to non-zero anyway.

galee wrote: As I metioned in the topic : www.deviationtx.com/forum/3-feedback-que...e6b-zip-doesn-t-work

DEVO7E seems something wrong about binding when use FIXID...

These days, I'm writing a Chinese Version for DEVO7E, the whole GUI is rewritten to reduce size, and the protocols is porting from PhracturedBlue's Deviation source.

When porting to devo.c (located at src\protocol), I found there may be a writing mistake:

I thought the code means when Model.fixed_id is zero, the tx will generate a random id and use_fixed_id will be zero (clear by initialize line 507), but when Model.fixed is set, use_fixed_id should be no-zero.

And there is another place make me confuse... function bind() line 491, is it mean whatever the Model.fixed is, the use_fixed_id is always 1?

Hope for answer~

Looks cool! I am also writing a GUI system (just started) which I hope that takes less resource and are more programmer friendly.

galee wrote: here is some snapshot about the Chinese firmware, is there anybody can give me a Traditional Chinese 12dot font file? If has pls send to This email address is being protected from spambots. You need JavaScript enabled to view it.

The deviation firmware does not support chs and cht because the flash size is small...

so I wrote another firmware, if you are chinese too, can visit 5IMX to get newest message.

I will public the source code soon~

Yes, I will open the source in few days. another question, I don't know how to post it , may I email it to you, or post in this forum as a attachment?

i believe most people here do it on bitbucket.

galee wrote: Yes, I will open the source in few days. another question, I don't know how to post it , may I email it to you, or post in this forum as a attachment?

I have changed the code to '1', it still has problem when FIXEDID BINDING, after many times try, I found it do work if I insert 'initialize()' into the function 'bind()'....

it'ok now... but it seems not a good modification, the code can be more pretty...

look forward for cht version's deviation F/W, thanks!!

it may be a bug about RX... I'm not test it in little plane such as mini-cp, my RX is RX1002, after many many many times test, I think you are right, the RX has something wrong.

I meet many problem when setup a hg enviroment.....

My HotenX binds with Fixed ID. The behaviour, however is different than with Devention: When I switch off the transmitter and switch it on again, connection is not reestablished (this works with Devention). Furthermore, the HotenX still binds with a second transmitter without FixedID (Devention F4) I did use "bind" after setting up the Fixed ID on DEVO 7E (deviation-devo7e-5b6a882e48b5, 2.02.13).

I've already public the source code on bitbucket.org/galee/galee-devo7e

Thank u again very much.

And during debug of DSMX, I found the 'model' has been set to zero, I try to change the model add to CYRF_MfgId[2] instead of CYRF_MfgId[3], it seems work well.

could galee's firmware be made english by replacing the three /src/HK12* files with english versions?

phil

Hi Galee :

where can I get the file system ?

thank you.