GUI

Sorry, it was a file type restriction...

It's not that good to put into the repo yet.
I have to find some better images...
It's just the concept, that we need some warnings, holds, etc...

What do you think of these icons initially?

Note: You can make toggle.bmp as wide as you want (in multiples of 32) it justr must be 31pixels high.

Oh, I must have forgotten about that!

Yep, it is nice, I just need one for the throttle hold, That is the only one I use them for...

Here it is with throttle hold

I updated the code to allow templates to be named *.ini (as long as it is still in 8.3 format). Note that the one thing you lose with this change is that it is now impossible to get consistent ordering of the templates on the page. there is no easy way to sort them, s they will show up in the order they exist in the filesystem (random)

Yep, I was expecting that, but not a big deal IMO.
Just like the languages...

One more possible feature request:
Would you make it possible to select a picture for the model icon.
It could be like the model select (file names in the list, actual picture shown on the left), but it should only show the image files of proper size...

FDR wrote: One more possible feature request:
Would you make it possible to select a picture for the model icon.
It could be like the model select (file names in the list, actual picture shown on the left), but it should only show the image files of proper size...

Done. But it will show all icons in the 'modelico' dir. If you put a wrong-size icon in there, it will not work properly.

I've made the "Icon" button translatable, and put the label into lang.hu.
Pushed...

I just checked in support for virtual channels since it was really easy to do.
Basically, you can set the trim output to be a channel rather than an input, and it will directly modify the channel output.
You can use any button for this (so left/right and up/down also work). Using ENT/EXT would probably be a bad idea though.

If you choose a button that is used elsewhere (like up/down or left/right) they will only work in virtual channel mode from the main page.

Cool!
I'll try...

I would like to change the order of controls on the channel page to help it understand better. I thought it would be better to show the settings in the order they are applied, and separate the failsafe from the others with some space to sign that it is something different.
My question is: what is the final order of these?
safety -> subtrim -> scale -> min/max limit -> reverse ?

Oops. I've just seen that you rearranged that page, I suppose to gain some space to the translated labels.
I have to say, that I liked the previous look more...

Anyway, I still think, that we should order them to match the order they are applied. It would help to understand they meaning and use...

EDIT: if this one column arrangement stays, we should use some more obvious label in that larger space...

FDR wrote:
Oops. I've just seen that you rearranged that page, I suppose to gain some space to the translated labels.
I have to say, that I liked the previous look more...

Me too, but this is a lot more flexible. The Russian translation is particularly long and needs the additional space

Anyway, I still think, that we should order them to match the order they are applied. It would help to understand they meaning and use...

Sure.
The order is trim -> subtrim -> scale -> reverse ->safety ->max/min
But that order really doesn't look right. I think it should probably be:
Trim -> safety -> subtrim -> scale -> reverse -> min/max
or possibly
Trim -> safety -> scale -> subtrim -> reverse -> min/max

Note that 'Trim' doesn't appear on this page, however I added it for completeness.

EDIT: if this one column arrangement stays, we should use some more obvious label in that larger space...

sure

Why the min/max is after the reverse? This way an assymetrical min/max values should be switched if one set the reverse after...

BTW I have some minor tweak request too:
The toggle bitmap selection should have cancel, if I don't want to change, just take a look. Especially, that it isn't indicated, which is the actually selected one...

FDR wrote: BTW I have some minor tweak request too:
The toggle bitmap selection should have cancel, if I don't want to change, just take a look. Especially, that it isn't indicated, which is the actually selected one...

bitbucket.org/PhracturedBlue/deviation/issues/new

Why the min/max is after the reverse? This way an assymetrical min/max values should be switched if one set the reverse after...

Because I didn't think it through very well. You are right that makes more sense.

If I think about it more, may be it is still better to have the min/max last...
While ordering them as they are applied will help to understand, it is not necessarily the order they will be set.
Probably everybody starts a setup with setting the reverses. Subtrims (i.e. centering a servo) and especially limiting the servo throw to be safe will be the last steps...

PhracturedBlue wrote: I think it should probably be:
Trim -> safety -> subtrim -> scale -> reverse -> min/max
or possibly
Trim -> safety -> scale -> subtrim -> reverse -> min/max

If the subtrim is used strictly for centering the servo arm, then it should be after the scaling...