PB's newgui

Kdean wrote: Oh wait, can you fix the model name, signal strenght, and battery voltage in the top bar???

Yes all of that is already done in the code. I just haven't uploaded an emulator with it yet.

Now the header is much better with the add button.

11. Could the long mouse press select the element before opening the popup, when we press on a deselected one?

12. When you step throw the elements with the keyboard, the text is black on the actual but not selected elements, which is barely visible on the ones with dark grey background.

rbe2012 wrote: Having the dialogs popping up for the properties (and enough space) I would propose to add a button "select icons" for the toggles (rather than pressing the source button).

Yep. Or at least do not make it clickable if "None" is selected...

I do welcome that now there are more options on the "Add Element" dialog, however I think it is time to rename then...

IMO it would be better if it only had a cancel button at the bottom, and only the first spinbox would be labelled as "Add" with a separate add button...

FDR wrote: I do welcome that now there are more options on the "Add Element" dialog, however I think it is time to rename then...

IMO it would be better if it only had a cancel button at the bottom, and only the first spinbox would be labelled as "Add" with a separate add button...

With the 'Erase' option I added, I don't think this makes sense.
When you press 'Erase' it marks the screen to be erased but it doesn't apply until you press 'Ok' That way you don't accidently erase all your work.

The template loading doesn't return to the dialog, so that one probably doesn't matter.

I can see how an 'Add' button might be more clear, but I'm not convinced. Can you give me an idea of how you would layout the current dialog given its functionality?

Also, I just uploaded a new snapshot of the devo12 emulator.
Note that the model.ini syntax changed. you need to change the [gui] section to [gui-480x272] ([gui-320x240] for the devo8). I don't see any way to make supporting the old gui possible now without a lot of crufty code. instead I will just use the default.ini if I don't find the new-gui section in the model.ini. Transferring models between different Tx models will result in losing any layout configuration, and fall back to the default.

Templates are now supported both from the /layout dir and reading from models.

Well, this is the point, which proves me: when I erased the form, I didn't realize, that the OK is the confirmation. I thought it is already erased...

The cancel button is clear: I want to close the dialog without adding an element, loading a template, erasing the whole form, or whatsoever...

However the OK button is unclear what will cause. It has two functions: adds a control or confirms the erasing, which is confusing..

I prefer the more conventional way:
- a separate add button, which I'm sure will add the selected element, but nothing more;
- the template loading, which will open an other dialog to select the template, but I can cancel it there anyway;
- and an erase all button, which closes this dialog and shows a confirmation message with an OK and a Cancel button, without the need to coming back to this editing dialog.
Probably there will be other options too in the future...

The last thing is the dialog's name, which shouldn't be "Add Element", since it already has two more functions...

I'm not sure about the icon from which the dialog opens.
While it suggests only the adding functionality, that is the most common usage, so it might do.

BTW I would add an other button to the header: an editing one, which would duplicate the function of the ENT key and the long pen press. It would be much more intuitive for the clicking users. Ideally it would only be shown if an element is selected...

Kdean wrote: I found that if i erase the model icon and exit the gui setup, there is no way to get back to the model settings. That could be a big problem. What happened to the little gear icon that used to pop up in the menu bar???

Good catch. I've checked in the fix. It'll be there nexttime I generate an exe.